Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add Snyk badges to component and utility packages #424

Merged
merged 8 commits into from
Apr 10, 2019
Merged

Add Snyk badges to component and utility packages #424

merged 8 commits into from
Apr 10, 2019

Conversation

amywalkerdev
Copy link
Contributor

@amywalkerdev amywalkerdev commented Apr 7, 2019 •
edited
Loading

Resolves #411

Overall change: Adds Snyk badges to each package readme to show vulnerabilities.

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@amywalkerdev amywalkerdev self-assigned this Apr 7, 2019
@amywalkerdev amywalkerdev added the ws-home Tasks for the WS Home Team label Apr 8, 2019
j-pendlebury
j-pendlebury suggested changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment but otherwise looks good

packages/components/psammead-figure/README.md Outdated Show resolved Hide resolved
j-pendlebury
j-pendlebury previously approved these changes Apr 8, 2019
View reviewed changes
dr3
dr3 suggested changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these packages need to be bumped and have a changelog

@amywalkerdev
Copy link
Contributor Author

All of these packages need to be bumped and have a changelog

Done

@amywalkerdev amywalkerdev requested review from dr3 and j-pendlebury April 8, 2019 09:00
j-pendlebury
j-pendlebury previously approved these changes Apr 8, 2019
View reviewed changes
dr3
dr3 suggested changes Apr 8, 2019
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@amywalkerdev amywalkerdev requested review from dr3 and j-pendlebury and removed request for dr3 April 8, 2019 10:57
dr3
dr3 suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve conflicts

Amy Walker added 2 commits April 9, 2019 15:56
@amywalkerdev amywalkerdev requested a review from dr3 April 9, 2019 15:20
j-pendlebury
j-pendlebury previously approved these changes Apr 9, 2019
View reviewed changes
dr3
dr3 previously approved these changes Apr 9, 2019
View reviewed changes
@jamesbrumpton
Copy link
Contributor

LGTM. Happy for this to be merged.

@amywalkerdev amywalkerdev dismissed stale reviews from dr3 and j-pendlebury via 0adeb8c April 10, 2019 11:43
@amywalkerdev amywalkerdev requested review from dr3 and j-pendlebury and removed request for dr3 April 10, 2019 11:44
dr3
dr3 approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge merge merge merge

@jamesdonoh jamesdonoh merged commit 4f7a904 into latest Apr 10, 2019
@jamesdonoh jamesdonoh deleted the snykbadges branch April 10, 2019 12:37
@thekp thekp mentioned this pull request Jul 12, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sareh sareh sareh approved these changes

@dr3 dr3 dr3 approved these changes

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

Assignees

@amywalkerdev amywalkerdev

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amywalkerdev @jamesbrumpton @sareh @dr3 @j-pendlebury @jamesdonoh